Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to Node.js v10 #6759

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Update to Node.js v10 #6759

merged 1 commit into from
Jun 27, 2019

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 26, 2019

The only package that needed to be updated was sha3. It has been updated to v1.2.3, which is a maintenance release that supports up to Node.js v12.

@Gudahtt Gudahtt requested a review from whymarrh as a code owner June 26, 2019 21:08
whymarrh
whymarrh previously approved these changes Jun 27, 2019
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks @Gudahtt!

The only package that needed to be updated was `sha3`. It has been
updated to v1.2.3, which is a maintenance release that supports up to
Node.js v12.
@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 27, 2019

I noticed when testing out Node v12 that there were two different versions of sha3 in the lockfile - 1.2.2 and 1.2.3 (the former supports Node v10, and the latter supports Node v12). I have just updated it to use only 1.2.3, to make switching to Node v12 easier in the future.

@danfinlay danfinlay merged commit 90eb5c4 into MetaMask:develop Jun 27, 2019
@Gudahtt Gudahtt deleted the node-v10 branch July 5, 2019 01:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants