Show recipients alias on header #6944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
reviewed
Aug 2, 2019
Krist14n
force-pushed
the
show-recipients-alias-on-header
branch
2 times, most recently
from
2520e1b to
ce574db
Compare
whymarrh
force-pushed
the
show-recipients-alias-on-header
branch
from
24f8316 to
23b0071
Compare
|
@Krist14n I rebased this on the latest |
whymarrh
suggested changes
Aug 8, 2019
| @@ -19,6 +19,7 @@ export default class SenderToRecipient extends PureComponent { | |||
| senderAddress: PropTypes.string, | |||
| recipientName: PropTypes.string, | |||
| recipientAddress: PropTypes.string, | |||
| recipientNickname: PropTypes.object, | |||
There was a problem hiding this comment.
I think this might need to be PropTypes.string:
Suggested change
| recipientNickname: PropTypes.object, | |
| recipientNickname: PropTypes.string, |
There was a problem hiding this comment.
It most definitely should be a PropTypes.string
whymarrh
force-pushed
the
show-recipients-alias-on-header
branch
from
b54d02d to
17bc4a5
Compare
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the account's alias on the header for the
SenderToRecipientcomponent