Fix Ledger account index check for account zero #8163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Ledger keyring to fix bug when trying to sign with account 0
whymarrh
approved these changes
Mar 4, 2020
danfinlay
added a commit
that referenced
this pull request
Mar 4, 2020
* Version v7.7.7 * Update `@metamask/eth-ledger-bridge-keyring` (#8162) * Update `@metamask/eth-ledger-bridge-keyring` The Ledger keyring has been updated to ensure that any stale BIP44 accounts created prior to v7.7.6 of the extension are discarded when the extension starts. Any attempts to sign with these accounts would have failed; they needed to be re-added regardless. * Update changelog * Fix Ledger account index check for account zero (#8163) Update Ledger keyring to fix bug when trying to sign with account 0 Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
added a commit
that referenced
this pull request
Mar 5, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Ledger keyring to fix bug when trying to sign with account 0