Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable disconnecting a single or all accounts #8496

Merged
merged 6 commits into from
May 2, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented May 1, 2020

  • Enables disconnecting a single or all accounts via the ConnectedSites popover
    • Disconnecting the single, last account from a site is equivalent to disconnecting all accounts
      • Therefore the, Disconnect all accounts option is displayed conditionally
    • The two different Popover components rendered by ConnectedSites have been factored out into two different render methods.

Result

image

@rekmarks rekmarks requested a review from a team as a code owner May 1, 2020 23:04
@rekmarks rekmarks force-pushed the permissions-disconnect branch from 755d5ad to 77a132f Compare May 1, 2020 23:08
@rekmarks rekmarks changed the base branch from perm-selector-refactor to develop May 1, 2020 23:48
@rekmarks rekmarks force-pushed the permissions-disconnect branch from 77a132f to 1595868 Compare May 1, 2020 23:50
@metamaskbot
Copy link
Collaborator

Builds ready [7100a36]
Page Load Metrics (641 ± 13 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29433652
domContentLoaded5976946402713
load5986966412713
domInteractive5966946392713

@rekmarks rekmarks requested a review from Gudahtt May 2, 2020 01:56
@metamaskbot
Copy link
Collaborator

Builds ready [44c5a61]
Page Load Metrics (660 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30393431
domContentLoaded6107346583517
load6127366603517
domInteractive6107346583517

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 11aa402 into develop May 2, 2020
@rekmarks rekmarks deleted the permissions-disconnect branch May 2, 2020 03:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants