Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update eth-token-tracker #9056

Merged
merged 1 commit into from
Jul 22, 2020
Merged

update eth-token-tracker #9056

merged 1 commit into from
Jul 22, 2020

Conversation

brad-decker
Copy link
Contributor

@brad-decker brad-decker commented Jul 22, 2020

Updates our eth-token-tracker dependency that was recently updated as a partial solution for #5055, namely the value of tokens showing as 0.000 when the value is greater than 0.000

MetaMask/eth-token-tracker#44

Work Remaining
Fix E2E tests that are broken by this. I guess it was a breaking change.

@brad-decker brad-decker requested a review from a team as a code owner July 22, 2020 19:45
@brad-decker brad-decker marked this pull request as draft July 22, 2020 19:51
@brad-decker brad-decker force-pushed the update-eth-token-tracker branch from 7c897b1 to c1fcee7 Compare July 22, 2020 20:08
@brad-decker brad-decker marked this pull request as ready for review July 22, 2020 20:26
@metamaskbot
Copy link
Collaborator

Builds ready [c1fcee7]
Page Load Metrics (681 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36114622713
domContentLoaded40385168010953
load40485368110953
domInteractive40285167910953

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 21292a8 into develop Jul 22, 2020
@brad-decker brad-decker deleted the update-eth-token-tracker branch July 22, 2020 20:31
Gudahtt added a commit that referenced this pull request Jul 23, 2020
@Gudahtt Gudahtt mentioned this pull request Aug 7, 2020
@sleazyp
Copy link

sleazyp commented Nov 7, 2020

id like to delete unsused or token addy with an error in it..... i click on hide and it always reappears..... i have a dozen of unused tokens and now i have to scroll down fo find balances

@Gudahtt
Copy link
Member

Gudahtt commented Nov 7, 2020

@sleazyp That problem is tracked here: #5055

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants