Fix require-unicode-regexp issues #9212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #8982
See
require-unicode-regexp
for more information.This change enables
require-unicode-regexp
and fixes the issues raised by the rule.But what is the
u
flag?Unicode-aware regular expressions in ES2015 covers the most of it, I'd recommend skimming the sections.
My opinionated summary:
Impacts of the
u
flag:\u{1234}
are now Unicode code point escapes instead of matching 1234 consecutive u symbols\a
(where a is not an escape character) now error because\a
is not a reserved escape sequence.
now matches unicode symbols*
,+
,?
, and{2}
,{2,}
,{2,4}
now work on unicode symbolsu
andi
flags is weird because it does case folding