move footer buttons to scrollable area #9228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems this change also effected the ConfirmApprove Screen which will not render the footer for that transaction screen. CI Failure Screenshot
The screenshot is not explicitly clear that the buttons for the footer are missing, since we expanded the full transaction details, but they are missing. |
|
Thanks @PatrykLucka! I'm pulling this down to review now. |
|
@tmashuang Your feedback has been resolved by the latest commit: GOOD: Long error message
GOOD: Confirm approve screenHorizontal scroll bar is pre-existing: moving onto code review. |
brad-decker
suggested changes
Aug 17, 2020
...rm-page-container/confirm-page-container-content/confirm-page-container-content.component.js
Outdated
Show resolved
Hide resolved
brad-decker
approved these changes
Aug 18, 2020
Gudahtt
pushed a commit
that referenced
this pull request
Aug 19, 2020
Co-authored-by: Patryk Łucka <patryk.lucka@consensys.net>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the confirm/cancel buttons to the scrollable region, so they cannot be clicked until all errors/warnings have been seen.
Fixes #9136