Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use Date scalars from graphql-scalars instead of custom ones #1435

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Use Date scalars from graphql-scalars instead of custom ones #1435

merged 3 commits into from
Jun 7, 2023

Conversation

MichalLytek
Copy link
Owner

@MichalLytek MichalLytek commented Mar 24, 2023 •
edited
Loading

  • make graphql-scalars package a peer dependency
  • use date scalars from graphql-scalars
  • remove custom date scalars
  • remove dateScalarMode option from buildSchema

@MichalLytek MichalLytek added the Enhancement 🆕 New feature or request label Mar 24, 2023
@MichalLytek MichalLytek added this to the 2.0 release milestone Mar 24, 2023
@MichalLytek MichalLytek self-assigned this Mar 24, 2023
@MichalLytek MichalLytek marked this pull request as draft March 24, 2023 11:20
@MichalLytek MichalLytek added the Blocked 🚫 Resolving this issue is blocked by other issue or 3rd party stuffs label Mar 24, 2023
@carlocorradini
Copy link
Contributor

Awesome 😎

@MichalLytek MichalLytek removed the Blocked 🚫 Resolving this issue is blocked by other issue or 3rd party stuffs label May 29, 2023
@MichalLytek MichalLytek marked this pull request as ready for review May 29, 2023 09:51
@MichalLytek MichalLytek merged commit 480ec1d into master Jun 7, 2023
@MichalLytek MichalLytek deleted the graphql-scalars branch June 7, 2023 07:59
@russell-dot-js russell-dot-js mentioned this pull request Jun 23, 2023
Open
@bandhan-majumder bandhan-majumder mentioned this pull request Jan 31, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@MichalLytek MichalLytek

Labels
Enhancement 🆕 New feature or request
Projects
None yet
Milestone
2.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@MichalLytek @carlocorradini