Merge pull request #21 from DylanHojnoski/fix-instructor-link

Michigan-Tech-Courses · Oct 26, 2024 · 9b16234 · 9b16234
2 parents adfb4c2 + c4f9c57
commit 9b16234
Show file tree

Hide file tree

Showing 11 changed files with 5,912 additions and 4,753 deletions.
diff --git a/src/lib/constants.ts b/src/lib/constants.ts
@@ -2,7 +2,7 @@ export const FACULTY_PAGES = [
   'https://www.mtu.edu/cs/department/people/',
   'https://www.mtu.edu/chemistry/people-groups/faculty-staff/',
   'https://www.mtu.edu/biomedical/people/faculty/',
-  'https://www.mtu.edu/cee/people/faculty-staff/',
+  'https://www.mtu.edu/cege/people/faculty-staff/',
   'https://www.mtu.edu/ece/department/faculty/',
   'https://www.mtu.edu/ef/department/faculty-staff/',
   'https://www.mtu.edu/geo/department/faculty/',
@@ -20,5 +20,6 @@ export const FACULTY_PAGES = [
   'https://www.mtu.edu/vpa/department/faculty/',
   'https://www.mtu.edu/computing/applied-computing/faculty/',
   'https://www.mtu.edu/business/people-groups/faculty-staff/',
-  'https://www.mtu.edu/forest/about/faculty-staff/'
+  'https://www.mtu.edu/forest/about/faculty-staff/',
+  'https://www.mtu.edu/psychology/people/'
 ];
diff --git a/src/lib/faculty.ts b/src/lib/faculty.ts
@@ -14,14 +14,19 @@ export const getAllFaculty = async (): Promise<IFaculty[]> => {
 
     const $ = cheerio.load(body);
 
-    const department = trim($('.site-title span > a').text());
+    const department = trim($('.title span > a').text());
 
     const people: IFaculty[] = [];
-
     $('.person').each((_, element) => {
       const node = $(element);
 
-      let name = trim(node.find('.personal > h2').text());
+      let nameElement = node.find('.personal h2 a');
+
+      if (nameElement.length === 0) {
+        nameElement = node.find('.personal h2');
+      }
+
+      let name = trim(nameElement.text());
 
       // Remove any attributes after name
       if (name.includes(',')) {

diff --git a/test/faculty.ts b/test/faculty.ts
@@ -19,7 +19,7 @@ test('getAllFaculty() works correctly', async t => {
     .get('/business/people-groups/faculty/')
     .reply(200, await fs.promises.readFile('./test/resources/faculty-with-obfuscated-emails.html'))
 
-    .get('/cee/people/faculty-staff/')
+    .get('/cege/people/faculty-staff/')
     .reply(200, await fs.promises.readFile('./test/resources/faculty-with-attributes.html'));
 
   const people = await getAllFaculty();

diff --git a/test/helpers/constants.ts b/test/helpers/constants.ts
@@ -2,5 +2,5 @@ export const FACULTY_PAGES = [
   'https://www.mtu.edu/cs/department/people/',
   'https://www.mtu.edu/chemistry/people-groups/faculty-staff/',
   'https://www.mtu.edu/business/people-groups/faculty/',
-  'https://www.mtu.edu/cee/people/faculty-staff/'
+  'https://www.mtu.edu/cege/people/faculty-staff/'
 ];
diff --git a/test/resources/chemistry-faculty.html b/test/resources/chemistry-faculty.html
diff --git a/test/resources/cs-faculty.html b/test/resources/cs-faculty.html
diff --git a/test/resources/faculty-with-obfuscated-emails.html b/test/resources/faculty-with-obfuscated-emails.html