Fix wrong links to "Heterogeneous Lookup in Associative Containers" #5396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit fd729a9: ✅ Validation status: passed
For more details, please refer to the build report. |
|
@TylerMSFT - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
TylerMSFT
reviewed
Jun 11, 2025
TylerMSFT
requested changes
Jun 11, 2025
There was a problem hiding this comment.
@Rageking8 - I have a question about the removal of -c14. Looks like it is necessary. This is what I see when I copy the anchor link in the browser:
#heterogeneous-lookup-in-associative-containers-c14 <--- c14
Rageking8
commented
Jun 12, 2025
TylerMSFT
approved these changes
Jun 12, 2025
|
#sign-off |
Rageking8
deleted the
fix-wrong-links-to-heterogeneous-lookup-in-associative-containers
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why so many of these links point to the wrong
sequence_containersanchor. Theheterogeneous-lookup-in-associative-containersanchor is added as the defaultheterogeneous-lookup-in-associative-containers-c14one might give wrong connotations about C (although C14 does not actually exist). Kebab case is chosen over snake case since the default one is as such.