-
Notifications
You must be signed in to change notification settings - Fork 701
Correct fingerprint algorithm to SHA1 #1607
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
@iinuwa : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit ddbf303: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit 3891c3b: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit c700223: ✅ Validation status: passed
For more details, please refer to the build report. |
@OwenRichards1 - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Is this note for me or MSFT? |
This is a note for @OwenRichards1. |
Entra uses SHA-1 fingerprints throughout the product (in the Portal, CLI, etc.). If you try to use a SHA256 fingerprint in
x5t
for the client assertion, an error is thrown. Changing it to SHA-1 works.Furthermore, the JWT specification states that
x5t
is explicitly a SHA-1 value, and thatx5t#S256
is a SHA-256 value.I think this is a typo and should be fixed.