File Type Policy API #4494
Merged
File Type Policy API #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-risney
requested changes
Apr 22, 2024
Master-Ukulele
commented
May 1, 2024
Master-Ukulele
commented
May 1, 2024
kmahone
reviewed
May 2, 2024
oldnewthing
reviewed
May 7, 2024
MikeHillberg
reviewed
May 7, 2024
dmachaj
reviewed
May 7, 2024
dmachaj
reviewed
May 7, 2024
dmachaj
reviewed
May 7, 2024
dmachaj
reviewed
May 7, 2024
david-risney
requested changes
May 7, 2024
The rewrite will address the following suggestions: - use m_webview2_25 to match the patterns and simplify to remove the null check. - case insensitive comparison - avoid memory leak with wil::unique_cotaskmem_string - include period for file extension - replace .exe to .iso - show the case of validating a trusted uri for .eml - show the case of using deferral and customized UI
david-risney
approved these changes
May 22, 2024
david-risney
added
the
review completed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the review for new File Type Policy API