Add spec for CoreWebView2ControllerOptions.DefaultBackgroundColor.md #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-risney
requested changes
Oct 30, 2024
vickiez
reviewed
Oct 30, 2024
citlalli-z
force-pushed
the
api-CoreWebView2ControllerOptions.DefaultBackgroundColor-draft
branch
3 times, most recently
from
33fde7c to
08674c7
Compare
Update to address feedback from review comments
citlalli-z
force-pushed
the
api-CoreWebView2ControllerOptions.DefaultBackgroundColor-draft
branch
from
08674c7 to
bad09b9
Compare
bradp0721
requested changes
Nov 4, 2024
vickiez
reviewed
Nov 8, 2024
| return S_OK; | ||
| } | ||
|
|
||
| wil::com_ptr<ICoreWebView2ControllerOptions> stagingOptions;wil::com_ptr<ICoreWebView2ControllerOptions4> options4; |
There was a problem hiding this comment.
Suggested change
| wil::com_ptr<ICoreWebView2ControllerOptions> stagingOptions;wil::com_ptr<ICoreWebView2ControllerOptions4> options4; | |
| wil::com_ptr<ICoreWebView2ControllerOptions4> options4; |
There was a problem hiding this comment.
+make sure to change other instances of stagingOptions to options4 :)
citlalli-z
force-pushed
the
api-CoreWebView2ControllerOptions.DefaultBackgroundColor-draft
branch
4 times, most recently
from
6df85f0 to
8c25360
Compare
citlalli-z
force-pushed
the
api-CoreWebView2ControllerOptions.DefaultBackgroundColor-draft
branch
from
8c25360 to
614e9de
Compare
citlalli-z
force-pushed
the
api-CoreWebView2ControllerOptions.DefaultBackgroundColor-draft
branch
from
2a4b5ec to
462d39d
Compare
citlalli-z
merged commit 6f25685
into
api-CoreWebView2ControllerOptions.DefaultBackgroundColor
1 check passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a review for the new CoreWebView2ControllerOptions.DefaultBackgroundColor API.