Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix deployment order #52

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix deployment order #52

merged 1 commit into from
Jun 24, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Jun 21, 2024

Description

Deployment order was not correct because the build and the deploy went of async. Meaning it could finished deploying before building. this fixes that.

I was unable to test if it really works. but in theory the fix should work

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

Copy link

Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This code feels even 'cleaner' than it was before!

@uittenbroekrobbert uittenbroekrobbert merged commit f20743b into main Jun 24, 2024
14 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the fix-deployment branch June 24, 2024 06:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants