Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add return type declaration of load method #30

Merged

Conversation

franciscosantamaria
Copy link
Contributor

Hi, trying to remove all my deprecation messages in order to upgrade my application to Symfony , it shows me this message:

Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Minishlink\Bundle\WebPushBundle\DependencyInjection\MinishlinkWebPushExtension" now to avoid errors or add an explicit @return annotation to suppress this message.

it's safer to add the void return type to the load method

Copy link
Owner

@Minishlink Minishlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Minishlink Minishlink merged commit 6c97336 into Minishlink:master Jan 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants