Skip to content

Commit

Permalink
support RuntimeClass.handler, this will useful like nvidia is not the…
Browse files Browse the repository at this point in the history
… default runtime

Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
  • Loading branch information
zhangguanzhang committed Apr 13, 2024
1 parent b138f52 commit f8d97aa
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
6 changes: 6 additions & 0 deletions core/container_create.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ func (ds *dockerService) CreateContainer(
containerName := makeContainerName(sandboxConfig, config)
mounts := config.GetMounts()
terminationMessagePath, _ := config.Annotations["io.kubernetes.container.terminationMessagePath"]

sandboxHostcCofig, err := ds.client.InspectContainer(r.GetPodSandboxId())
if err != nil {
return nil, fmt.Errorf("unable to get container's sandbox ID: %v", err)
}
createConfig := dockerbackend.ContainerCreateConfig{
Name: containerName,
Config: &container.Config{
Expand All @@ -91,6 +96,7 @@ func (ds *dockerService) CreateContainer(
RestartPolicy: container.RestartPolicy{
Name: "no",
},
Runtime: sandboxHostcCofig.HostConfig.Runtime,
},
}

Expand Down
9 changes: 6 additions & 3 deletions core/sandbox_run.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"encoding/json"
"fmt"

"github.com/Mirantis/cri-dockerd/config"
"github.com/Mirantis/cri-dockerd/utils/errors"
v1 "k8s.io/cri-api/pkg/apis/runtime/v1"
Expand Down Expand Up @@ -51,9 +52,6 @@ func (ds *dockerService) RunPodSandbox(
}

// Step 2: Create the sandbox container.
if r.GetRuntimeHandler() != "" && r.GetRuntimeHandler() != runtimeName {
return nil, fmt.Errorf("RuntimeHandler %q not supported", r.GetRuntimeHandler())
}
createConfig, err := ds.makeSandboxDockerConfig(containerConfig, image)
if err != nil {
return nil, fmt.Errorf(
Expand All @@ -62,6 +60,11 @@ func (ds *dockerService) RunPodSandbox(
err,
)
}
// k8s RuntimeClass.handler=docker will use docker's default runtime
runtimeHandler := r.GetRuntimeHandler()
if runtimeHandler != "" && runtimeHandler != runtimeName {
createConfig.HostConfig.Runtime = runtimeHandler
}
createResp, err := ds.client.CreateContainer(*createConfig)
if err != nil {
createResp, err = recoverFromCreationConflictIfNeeded(ds.client, *createConfig, err)
Expand Down

0 comments on commit f8d97aa

Please # to comment.