Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deps: pin request version range #1

Merged
merged 1 commit into from
Apr 5, 2018
Merged

deps: pin request version range #1

merged 1 commit into from
Apr 5, 2018

Conversation

MissSheyni
Copy link
Owner

@MissSheyni MissSheyni commented Apr 5, 2018

Required for "node < 4" compatibility and is congruent with npm

minimum for passing npm test >= 2.9.0
setting < 2.82.0 allows deduping

PR-URL: nodejs#1300
Fixes: nodejs#1299
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Anna Henningsen anna@addaleax.net

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Required for "node < 4" compatibility and is congruent with `npm`

minimum for passing `npm test` >= 2.9.0
setting < 2.82.0 allows deduping

PR-URL: nodejs#1300
Fixes: nodejs#1299
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MissSheyni MissSheyni merged commit 8087dcb into master Apr 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install node-gyp under node 0.10.x SyntaxError: Use of const in strict mode
2 participants