Remove dependency version properties from cosmic-core pom. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@borisroman: why would the build be broken with failed unit tests? |
|
@miguelaferreira Rebased the pr on cosmic. Everything passes now. |
borisroman
force-pushed
the
remove/pom_dependency_properties
branch
from
7fb4375 to
e77ec1c
Compare
These properties are already defined in the top-level cosmic pom.
borisroman
force-pushed
the
remove/pom_dependency_properties
branch
from
e77ec1c to
ccc71d0
Compare
|
Ran integration tests again: https://beta-jenkins.mcc.schubergphilis.com/job/cosmic/job/0002-tracking-repo-branch-build/139/ All green, ping @miguelaferreira |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties are already defined in the top-level cosmic pom.
Integration tests succeeded: https://beta-jenkins.mcc.schubergphilis.com/job/cosmic/job/0002-tracking-repo-branch-build/139/