Remove dependency version properties from cosmic-core pom. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@borisroman: why would the build be broken with failed unit tests? |
borisroman
force-pushed
the
build/remove/pom_dependency_properties
branch
from
d3063ed to
28352f2
Compare
borisroman
force-pushed
the
build/remove/pom_dependency_properties
branch
from
28352f2 to
93d8ea7
Compare
|
@miguelaferreira Rebased this pr, now everything passes. |
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| <properties> | |||
| <maven.javadoc.skip>true</maven.javadoc.skip> | |||
| <cs.jdk.version>1.8</cs.jdk.version> | |||
| <cs.jdk.version>1.7</cs.jdk.version> | |||
|
I'll leave the cosmic pom at Java 8. |
bheuvel
pushed a commit
that referenced
this pull request
Jun 20, 2016
…rectory Restore build/ directory
bheuvel
pushed a commit
that referenced
this pull request
Jun 20, 2016
Static route display in the UI
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties are already defined in the top-level cosmic pom. Before, the java version property was set in the cosmic-core. Now we define it here.
Integration tests succeeded: https://beta-jenkins.mcc.schubergphilis.com/job/cosmic/job/0002-tracking-repo-branch-build/128/
Merge together with: MissionCriticalCloudOldRepos/cosmic-core#183