Make stopVirtualMachine use the force parameter #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of ACS
|
Go build |
|
Tested on KVM, after ~2min when the VM cannot shutdown (I removed several binaries and config scripts so it couldn't do it), it was forcefully stopped. |
|
Shall I merge @remibergsma? |
|
this one as well, @remibergsma ? |
|
Let me verify on XenServer (building a setup as we speak). Will let you know soon.. |
|
Tested and verified that stopping without force still results in a proper shutdown. Then also verified that force=true results in an immediate shutdown of the VM (it didn't try to be nice first, like KVM). Anyway, good to be merged @bheuvel @miguelaferreira @wilderrodrigues |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of ACS