Fix searching for POD id #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
go build |
1 similar comment
|
go build |
remibergsma
force-pushed
the
fix/pod-id-search
branch
from
38f3d47 to
4f14206
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value
pod_idinvm_instanceis not kept up2date. Use the value from thehostinstead. This fixes the search onpod_idin thelistVMscall. Also, since it is not up2date, do not check it when deleting a pod. It was meant for basic zone networking, which is not supported anymore anyway so it's not an issue to remove the check.