Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

바뀐 API URL 적용 +a #54

Open
3 of 5 tasks
mjms0214 opened this issue Aug 6, 2023 · 2 comments · Fixed by #59
Open
3 of 5 tasks

바뀐 API URL 적용 +a #54

mjms0214 opened this issue Aug 6, 2023 · 2 comments · Fixed by #59
Assignees
Labels
Add New feature or request Refactor This doesn't seem right

Comments

@mjms0214
Copy link
Collaborator

mjms0214 commented Aug 6, 2023

내용

제곧내

작업 내용

  • API URL 수정(Back Repository issue#62 참고)
    -> test 진행중
  • 마이페이지 내 강의 삭제, 회원 정보 수정 및 삭제 구현
    -> test 진행중
  • back api 글로벌 변수 선언
  • pagination 수정
    -> test 진행중
  • 자동채점 구현

참고 사항

@mjms0214 mjms0214 added the Refactor This doesn't seem right label Aug 6, 2023
@mjms0214 mjms0214 self-assigned this Aug 6, 2023
@mjms0214 mjms0214 changed the title API 타입 interface로 수정 바뀐 API URL 적용 Aug 6, 2023
@NayeonKeum
Copy link
Member

NayeonKeum commented Aug 7, 2023

API url을 아예 글로벌 변수로 선언하는 건 어떨까요? 앞으로 aws 아키텍처 구성하다가 dns 바뀔 수도 있을 것 같아서요!!

http://moaroom-back.duckdns.org:8080

이쪽 참고하시면 좋을 것 같습니다!!

https://github.com/BIND-2022/2022-G.Ipsa-SolutionChallenge/blob/299a0cc8e23eeffdb102709d6b990edb82aefba2/frontend/GIpsa/src/shared/utils/api.ts#L1-L15

https://github.com/BIND-2022/2022-G.Ipsa-SolutionChallenge/blob/299a0cc8e23eeffdb102709d6b990edb82aefba2/frontend/GIpsa/src/shared/constants/env.ts#L1-L3

  • 이건 저희가 사용하는 axios랑 다른 거긴 한데 이 라이브러리 말고 axios url 형식만 api.client로 맞추면 더 깔끔할듯합니다!

https://github.com/BIND-2022/2022-G.Ipsa-SolutionChallenge/blob/299a0cc8e23eeffdb102709d6b990edb82aefba2/frontend/GIpsa/src/shared/hook/useFollowers.ts#L7C1-L11C69

@mjms0214 mjms0214 changed the title 바뀐 API URL 적용 바뀐 API URL 적용 +a Aug 20, 2023
@mjms0214 mjms0214 added the Add New feature or request label Aug 20, 2023
@mjms0214
Copy link
Collaborator Author

API url을 아예 글로벌 변수로 선언하는 건 어떨까요? 앞으로 aws 아키텍처 구성하다가 dns 바뀔 수도 있을 것 같아서요!!

http://moaroom-back.duckdns.org:8080

이쪽 참고하시면 좋을 것 같습니다!!

https://github.com/BIND-2022/2022-G.Ipsa-SolutionChallenge/blob/299a0cc8e23eeffdb102709d6b990edb82aefba2/frontend/GIpsa/src/shared/utils/api.ts#L1-L15

https://github.com/BIND-2022/2022-G.Ipsa-SolutionChallenge/blob/299a0cc8e23eeffdb102709d6b990edb82aefba2/frontend/GIpsa/src/shared/constants/env.ts#L1-L3

  • 이건 저희가 사용하는 axios랑 다른 거긴 한데 이 라이브러리 말고 axios url 형식만 api.client로 맞추면 더 깔끔할듯합니다!

https://github.com/BIND-2022/2022-G.Ipsa-SolutionChallenge/blob/299a0cc8e23eeffdb102709d6b990edb82aefba2/frontend/GIpsa/src/shared/hook/useFollowers.ts#L7C1-L11C69

반영했습니다~ 나중에 pr 확인하시면 변경된 것 확인 가능하실겁니다ㅎㅎ

@mjms0214 mjms0214 mentioned this issue Aug 20, 2023
mjms0214 added a commit that referenced this issue Aug 20, 2023
@NayeonKeum NayeonKeum reopened this Aug 20, 2023
mjms0214 added a commit that referenced this issue Aug 20, 2023
modify API URL & request param
mjms0214 added a commit that referenced this issue Aug 22, 2023
NayeonKeum added a commit that referenced this issue Aug 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Add New feature or request Refactor This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants