feat: react js rules (#28)

* feat: react rules
MobileReality · Aug 8, 2022 · 16f41d4 · 16f41d4
1 parent d055af3
commit 16f41d4
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 11 deletions.
diff --git a/configs/eslint.js b/configs/eslint.js
@@ -28,5 +28,12 @@ module.exports = {
         'consistent-return': 'off',
         'prefer-named-capture-group': 'off',
         'class-methods-use-this': 'off',
+        'no-shadow': 'off',
+        'no-empty-function': [
+            'error',
+            {
+                allow: ['arrowFunctions'],
+            },
+        ],
     },
 };
diff --git a/configs/typescript.js b/configs/typescript.js
@@ -44,6 +44,11 @@ module.exports = {
         '@typescript-eslint/no-non-null-assertion': 'off',
         '@typescript-eslint/no-shadow': 'off',
         '@typescript-eslint/method-signature-style': 'off',
-        '@typescript-eslint/no-empty-function': 'off',
+        '@typescript-eslint/no-empty-function': [
+            'error',
+            {
+                allow: ['arrowFunctions'],
+            },
+        ],
     },
 };
diff --git a/react-javascript.js b/react-javascript.js
@@ -3,18 +3,21 @@ module.exports = {
     extends: ['./configs/eslint', './configs/unicorn', './configs/react'],
     rules: {
         'no-underscore-dangle': 'off',
+        'no-implicit-coercion': [
+            'error',
+            {
+                boolean: false,
+            },
+        ],
 
-        'unicorn/filename-case': 'off',
-        'unicorn/no-thenable': 'off',
-        'unicorn/no-useless-undefined': 'off',
-        'unicorn/numeric-separators-style': 'off',
-        'unicorn/prefer-module': 'off',
-        'unicorn/prefer-node-protocol': 'off',
-        'unicorn/prefer-regexp-test': 'off',
-        'unicorn/prefer-set-has': 'off',
+        // disabled because of https://github.com/sindresorhus/eslint-plugin-unicorn/issues/687
         'unicorn/prefer-spread': 'off',
-        'unicorn/template-indent': 'off',
-        'unicorn/text-encoding-identifier-case': 'off',
+        'unicorn/template-indent': [
+            'error',
+            {
+                indent: 4,
+            },
+        ],
 
         'simple-import-sort/exports': 'error',
         'simple-import-sort/imports': [