Skip to content

Support Python 3.13 #227

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Conversation

chezou
Copy link
Contributor

@chezou chezou commented Dec 10, 2024

Description

Support Python 3.13, including:

  • torch
  • cupy
  • lightfm
  • pytorch_lightning

excluding:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (a4e5418).
Report is 99 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #227     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        76     +31     
  Lines         2242      5163   +2921     
===========================================
+ Hits          2242      5163   +2921     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chezou chezou force-pushed the feature/py313 branch 4 times, most recently from 1152e98 to 384dfcc Compare December 10, 2024 21:35
@chezou chezou marked this pull request as ready for review December 11, 2024 00:31
@chezou chezou changed the title Feature/py313 Support Python 3.13 Dec 11, 2024
@chezou
Copy link
Contributor Author

chezou commented Dec 11, 2024

@feldlime Applied all the feedback, and CI passed. PTAL

chezou and others added 2 commits December 11, 2024 16:14
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
@chezou chezou force-pushed the feature/py313 branch 15 times, most recently from 03cebe9 to d27aeee Compare March 15, 2025 00:10
@chezou
Copy link
Contributor Author

chezou commented Mar 15, 2025

@feldlime I fixed the SASRec and BERT4Rec tests on 5e67d9c

Can you have a look?

@chezou
Copy link
Contributor Author

chezou commented Mar 20, 2025

Now, PyTorch 2.6 is supported, while pytorch_lightning is not available yet.

@chezou
Copy link
Contributor Author

chezou commented Mar 20, 2025

@feldlime @blondered I confirmed that Python 3.13 CI has passed with pytorch-lightning 2.5.1 and PyTorch 2.6 🎉

If there's no objection, can you review and approve it?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants