Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect game path update for game plugins with executable in subfolders #1346

Closed
Holt59 opened this issue Jan 9, 2021 · 2 comments · Fixed by #1351
Closed

Incorrect game path update for game plugins with executable in subfolders #1346

Holt59 opened this issue Jan 9, 2021 · 2 comments · Fixed by #1351
Labels
Dev Ticket Reserved for development tasks management.

Comments

@Holt59
Copy link
Member

Holt59 commented Jan 9, 2021

When updating the game path through the settings dialog, users have to specify the game executable and MO2 then deduce the game path from the executable.

Currently MO2 consider that the game folder is the folder containing the executable, which is not true for games for which the executable is in a sub-folder such as Darkest Dungeon from basic games.

This should be changed to take into account the actual value from binaryName()

https://github.com/ModOrganizer2/modorganizer/blob/master/src/settingsdialogpaths.cpp#L100

@Holt59 Holt59 added the Dev Ticket Reserved for development tasks management. label Jan 9, 2021
@isanae
Copy link
Contributor

isanae commented Jan 9, 2021

This is going to be a bit of a pain. The settings dialog doesn't care about game plugins right now, it actually uses what's in the texbox as a filter for the filename, it doesn't even ask the plugin. It'll have to get the binary path from the plugin and remove that from the selected path. It also means it has to check that the selected path ends with the binary path correctly.

@isanae
Copy link
Contributor

isanae commented Jan 10, 2021

Also, this is a showstopper for 2.4.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Dev Ticket Reserved for development tasks management.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants