Fix setting game path for games with executable in subfolder.

[Holt59]

Fixes #1346

[isanae]

That works fine, but I have two problems with it:

1. update() is called after the dialog is closed and doesn't handle failure. Either put the code in an editingFinished handler for the text box (which sucks because it pops a dialog), or add a new checkValid() member function in SettingsTab that's called from SettingsDialog::exec() and stops the process if one returns false.

2. The message is going to be confusing, some people will ask why you're trying to unzip the game folder. I'd say something really specific for cases where the binary name contains a directory, because it's not obvious that we're trying to find a parent folder that contains a specific path. You can also use a task dialog, put more info in the details and also log them.

[Holt59]

1. update() is called after the dialog is closed and doesn't handle failure. Either put the code in an editingFinished handler for the text box (which sucks because it pops a dialog), or add a new checkValid() member function in SettingsTab that's called from SettingsDialog::exec() and stops the process if one returns false.

The game path edit is read-only so I just moved the code in the "click" event, and I only update the edit if the path is valid. I'm using a member to avoid recomputing the path to save it when saving the settings.

2. The message is going to be confusing, some people will ask why you're trying to unzip the game folder. I'd say something really specific for cases where the binary name contains a directory, because it's not obvious that we're trying to find a parent folder that contains a specific path. You can also use a task dialog, put more info in the details and also log them.

I've changed the message, let me know what you think, I'm not really good at writing user warnings.

[isanae]

Can you add a short comment explaining what the cdUp loop is doing and why it has to do it?

[Holt59]

Can you add a short comment explaining what the cdUp loop is doing and why it has to do it?

Done.

[isanae]

Looks good to me.