-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix infot.mod #1
Conversation
Can you also add a brief note (1 line) to the readme indicating that the file has changed; see e.g. https://senselab.med.yale.edu/ModelDB/showmodel?model=2488&file=/cells/README.txt#tabs-2 |
still WIP - do not merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexsavulescu @kotsaloscv made some suggestions according to some changes I did in a similar file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok to me but have left some questions / remarks for @iomaganaris
@@ -1099,6 +1106,7 @@ static double tetrospks2 (double* X1d,double* X2d,double* XO,int szX1,int szXO,i | |||
cnt1/=sz; cnt2/=sz; // ignore if not enough of the windows are filled | |||
if (cnt1<binmin) return -11.; else if (cnt2<binmin) return -12.; | |||
if (binmax) if (cnt1>binmax) return -11.; else if (cnt2>binmax) return -12.; | |||
/* this should perhaps be fabs */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this (there's a C compiler warning) and was happy to leave it in, but I can remove it if you like.
With the current version of
infot.mod
I get the following warning when compiling with NEURON 9.0.0: