Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

New metrics are added for imbalanced classification #505

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

New metrics are added for imbalanced classification #505

wants to merge 5 commits into from

Conversation

mcavs
Copy link

@mcavs mcavs commented May 10, 2022

  • codes are added to model_performance function.
  • proper documentation is added to DALEX reference.
  • NEWS.md is updated.

@mcavs mcavs mentioned this pull request May 10, 2022
Closed
@hbaniecki hbaniecki self-requested a review May 10, 2022 19:50
pbiecek
pbiecek approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@pbiecek pbiecek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but why

  tp <- as.numeric(tp)
  fp <- as.numeric(fp)
  tn <- as.numeric(tn)
  fn <- as.numeric(fn)

is not also in baccuracy?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pbiecek pbiecek pbiecek approved these changes

@hbaniecki hbaniecki Awaiting requested review from hbaniecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcavs @pbiecek