Clean up the code of RichTextAnnotatedStringParser
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, I really liked the destruction it makes it cleaner. |
MohamedRejeb
requested changes
May 22, 2023
| } | ||
|
|
||
| val currentStyles = parts |
There was a problem hiding this comment.
The previous approach is better in term of performance, we only need to loop the parts a single time.
There was a problem hiding this comment.
You're right, reverted some of the changes.
MohamedRejeb
approved these changes
May 22, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foremost, thanks for the great library, we really needed that in compose multiplatform.
About PR:
Before release of 0.2.0 I tried to implement similar encoding and decoding functionality. I think the suggested solution is better.
For
encode, only the functional approach is used (compare to the mix of approaches previously).I also used destruction declaration for the
SpanStyleandRichTextPart.