Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NET 8.0 #173

Closed
wants to merge 4 commits into from
Closed

Conversation

TobiasJuderjahn
Copy link

Since Expecto still expects .NET6.0 it is just a proposal for updating the SDK part.

@7sharp9
Copy link
Collaborator

7sharp9 commented Jan 8, 2024

Build fails with this PR:
https://github.com/MoiraeSoftware/myriad/actions/runs/7449370138/job/20265896186

@7sharp9
Copy link
Collaborator

7sharp9 commented Jan 8, 2024

I dont know why theres it no direct output but: dotnet run --framework net6.0 --fail-on-focused-tests --summary --project ./test/Myriad.IntegrationPluginTests/Myriad.IntegrationPluginTests.fsproj -c Release is producing an error.

@7sharp9
Copy link
Collaborator

7sharp9 commented Jan 8, 2024

I wonder if the net6.0 part is the issue or something else.

@TobiasJuderjahn
Copy link
Author

I wonder if the net6.0 part is the issue or something else.

Ill check later. But would you agree that updating to 8.0 is usefull? It would be a breaking change?

@TobiasJuderjahn
Copy link
Author

The 6.0/8.0 mix is a smell. maybe we have to wait for Expecto to be updated?

@7sharp9
Copy link
Collaborator

7sharp9 commented Jan 8, 2024

Updating to 8.0 is fine, just need the build working to get the artefacts for nuget.

@TobiasJuderjahn
Copy link
Author

Would you please trigger the build? Last try.

@7sharp9
Copy link
Collaborator

7sharp9 commented Jan 10, 2024

Still fails

@7sharp9
Copy link
Collaborator

7sharp9 commented Feb 13, 2024

Want me to close?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants