Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

A missing return "derandom" in monika_conventions #10198

Open
wants to merge 2 commits into
base: content
Choose a base branch
from

Conversation

Wingdinggaster656
Copy link
Contributor

@Wingdinggaster656 Wingdinggaster656 commented Feb 13, 2024

The Conventions topic is a topic that asks players questions and then sets PM variables.

Since other topics related to PM variables seem to have return "derandom", I think this should also be included.

Copy link
Member

@dreamscached dreamscached Feb 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label v0_12_15(version="v0_12_15"):
python hide:
if mas_seenEvent("monika_conventions"):
mas_hideEVL("monika_conventions", derandom=True)
return

Better leave that to maintainers. We have no idea if the next release would be 0_12_x or 0_13_x ahead of time. This line will have no effect as the proposed changes did not appear in 0.12.15.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants