Monkeys now use filters & Simians are now monkeys (Attempt #2) #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3585b0a.
This makes it not work in pref menu properly but should hopefully cut down on the amount of times it gets called.
This was referenced Oct 18, 2024
code/modules/atmospherics/machinery/components/unary_devices/vent_scrubber.dm
Show resolved
Hide resolved
code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_monkey.png
Outdated
Show resolved
Hide resolved
Co-authored-by: wraith-54321 <69217972+wraith-54321@users.noreply.github.com>
This was referenced Oct 26, 2024
Closed
Open
Closed
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monkestation stopped being a fork and became an actual repo I can now fork off of, which fucked up github and made it endlessly get stuck 'processing' recent pushes which made it impossible for me to add any more commits
So now instead of figuring out how to actually fix this I just made a new PR instead.
About The Pull Request
Ports tgstation/tgstation#81598 which uses filters to allow monkeys to wear any clothes, and makes Simians a subtype of monkeys.
Simians now inherit the height filters among other monkey things like attack chain.
Ignore the half-opaque pixels sticking out the sides, it has been fixed.
The prefs menu's tail icons looks a little fucked up on local but I was told this is apparently normal and is fine on the server. For some reason, it loads just fine when running unit tests locally, so I used that to ensure they look right at the very least.
Monkeys now also use Simians' bodyparts, fur, and eyes
They now look like this
Also fixes monkeys sometimes not having a tail.
Why It's Good For The Game
Simians seems like just Monkey+ so why not just make it so, cuts down on some copy paste and should make it easier to change monkeys without having to mirror everything for Simians.
Monkeys also now make use of Fur and eye colors, cutting even more down on copy paste. Simians looking to replace body parts now only need to look for monkey cubes, as they can't get robotic limbs.
Changelog
🆑
add: Monkeys can now wear any outfit rather than just the waiter outfit.
add: Simians now use the same height filter system as Monkeys to wear outfits instead of having their own icon for each individual piece of clothing.
add: Monkeys now use the same prefs as Simians, having Fur and eye colors. By default monkeys are all brown, and simians can choose to be brown as well.
add: Simians and monkeys are now at the bottom of the tile they are on, rather than the middle.
del: Big legged species and monkey abominations.
fix: Gigantism no longer doubles your size twice.
/:cl: