Makes it more obvious in the lobby when there's a job overflow #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
|
This is currently on TM, especially given that issues are referencing this. This may be granted an exemption to the feature ban in place. |
This was referenced Dec 18, 2024
Closed
Closed
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
…station#4589) * Makes it more obvious in the lobby when there's a job overflow * fix a whoopsie there
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This adds some somewhat obvious notifications to the lobby - a chat notice, and an obvious doohickey on the menu itself showing the job icon and a flashing infinity symbol.
imo this is better than players not realizing there's an overflow, then just immediately cryoing when they end up in a job they dislike.
Also, I added a preference (disabled by default) to require the user to confirm that they want to ready up when there's an overflow.
just to clarify, you can figure out the overflow role in the lobby anyways if you manually check your job preferences, this just makes it practically impossible to miss
Screenshots
Chat notice
Visual indicator
Ready confirmation preference
REMINDER, YOU ONLY GET THIS PROMPT WHEN YOU EXPLICITLY ENABLE THE PREFERENCE
Why It's Good For The Game
Changelog
🆑
qol: There is now a chat notice and a visual indicator in the lobby for when there's a non-standard overflow.
qol: Added a preference (disabled by default) to confirm readying up when there's a non-standard overflow.
fix: Fixed a bug where the overflow station trait could roll assistants, which just did... nothing.
/:cl: