Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deals rather badly with cancelled comments #121

Open
xmo-odoo opened this issue Aug 4, 2020 · 3 comments
Open

Deals rather badly with cancelled comments #121

xmo-odoo opened this issue Aug 4, 2020 · 3 comments
Labels

Comments

@xmo-odoo
Copy link

xmo-odoo commented Aug 4, 2020

  1. create comment (with [+])
  2. hide all comments in file
  3. show comments
  4. cancel comment created at [1]
  5. hide comments again

Expected: no comment

Observed: a hidden comment mark with 0 next to it, seemingly impossible to get rid of without reloading the page entirely

@Mottie Mottie added the bug label Aug 4, 2020
@Mottie
Copy link
Owner

Mottie commented Aug 9, 2020

Hi @xmo-odoo!

Same here... I didn't get around to troubleshooting & fixing the problem this weekend.

@Mottie
Copy link
Owner

Mottie commented Sep 30, 2020

So when you hide all comments, this userscript is using the built-in setting to hide all comments, so that behavior hasn't changed. I'm not able to duplicate the mentioned problem anymore - maybe I'm missing something?

What I did fix was collapsed comments no longer collapse open editors.

Please let me know if you're still having this issue. If not, please close this issue. If it does still exist, please update the steps to reproduce the problem (if needed) and I'll take a look again soon.

@xmo-odoo
Copy link
Author

@Mottie issue doesn't occur anymore, though possibly because the "hidden comments" marker is gone? I think when I tested originally if comments were hidden (actually hidden not collapsed) there would be a gutter icon with the number of hidden comments at that point, and when a comment was cancelled that gutter icon was left with a count of 0.

I should have taken a screenshot, sorry about that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants