Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugs for GitHub custom hotkeys #125

Closed
dnknn opened this issue Aug 10, 2020 · 3 comments
Closed

Bugs for GitHub custom hotkeys #125

dnknn opened this issue Aug 10, 2020 · 3 comments
Labels

Comments

@dnknn
Copy link

dnknn commented Aug 10, 2020

Hi @Mottie !
Thanks for the release of version 1.1.0, optional to open in new tab, working perfectly by itself..
But other have a bug,

208_10200541

  1. Then, On the any page, can not use g q to popup this dialog box.
    https://github.com/........#hotkey-settings

  2. On the github homepage, it will also cause the left sidebar to be deformed.

https://github.com/#hotkey-settings

@Mottie
Copy link
Owner

Mottie commented Aug 10, 2020

HI @dnknn!

Hmm, it looks like the github home page does that no matter what bookmark you add to the url, e.g. https://github.com/#blah (but you have to type it in after the page is loaded)

@Mottie
Copy link
Owner

Mottie commented Aug 10, 2020

I do understand; but there is something odd going on with that page when you add a hash. I didn't close this issue because I still need to spend time investigating why the settings popup doesn't open.

@Mottie Mottie added the bug label Aug 10, 2020
@dnknn
Copy link
Author

dnknn commented Aug 10, 2020

Ok. The previous version no this problem. can use the ⌨hotkey to popup,
but now can only use the 🖱mouse to click to popup. That's what it means.

@Mottie Mottie closed this as completed in aad15c9 Aug 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants