Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added UL to tips to protect self #7706

Merged
merged 4 commits into from
Oct 27, 2021
Merged

added UL to tips to protect self #7706

merged 4 commits into from
Oct 27, 2021

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Oct 27, 2021

Closes #7700
Related PRs/issues #7707

This PR was made to allow the users to add a UL in the "tips to protect yourself" field in the CMS. That way they can just create a bullet point for every "tip" and it will render correctly as a UL on the front end with the changes made in #7707.

Link to sample test page: https://foundation-s-7700-updat-yy2imi.herokuapp.com/cms/pages/23/edit/

Steps to test:

  1. Visit the CMS using the link above
  2. Scroll down to the "Tips to protect yourself" section"
  3. The section should now have 4 options: Bold, Italic, List, and Link.
  4. Please feel free to test out adding tips to the section and if everything is working as expected, testing is complete!
    Note: Please note however that since the front end changes have not been merged into master yet, the changes will not appear on the front end.

@mofodevops mofodevops temporarily deployed to foundation-s-7700-updat-yy2imi October 27, 2021 00:28 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@danielfmiranda
Copy link
Collaborator Author

Hi @Pomax, tagged you in this ticket as I wanted to double check I was working in the correct branches regarding a change to the already-live CMS, and the seperate branch front end product page. Thanks!

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-7700-updat-yy2imi October 27, 2021 01:46 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So speedy! This looks great in the CMS
image

@Pomax Pomax temporarily deployed to foundation-s-7700-updat-yy2imi October 27, 2021 16:28 Inactive
@Pomax
Copy link
Contributor

Pomax commented Oct 27, 2021

superceded by #7707

@Pomax Pomax closed this Oct 27, 2021
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@Pomax Pomax reopened this Oct 27, 2021
@mofodevops mofodevops temporarily deployed to foundation-s-7700-updat-ivgmls October 27, 2021 17:35 Inactive
@Pomax Pomax merged commit ba752ef into main Oct 27, 2021
@Pomax Pomax deleted the 7700-updated-product-tips branch October 27, 2021 17:35
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PNI CMS QA] - Update "tips to protect yourself" to use UL element.
4 participants