7623 - Subcategories - front-end styling for desktop

[fessehaye]

Closes #7623

Also includes some config changes for eslint and prettier for our node tests

Does not include mobile subcategory tasks

https://foundation-s-7620-pills-bdzrnb.herokuapp.com/en/privacynotincluded/

[sabrinang]

• add a bit more space above creep-o-meter introduction (~32px)
  

• From the mockups, it looks like the heading of the main category doesn't change and is clickable (dark-blue on hover) to reset the category (like as if you clicked the category from the navigation bar). See Figma mockup
  

• Some subcategory pages don't show the state where there isn't a product:
  

• Some others have it:
  

[Pomax]

A few notes - also it looks like seaching does not change the title on the page to "All", even though it does highlight the "all" entry in the nav bar:

done

[sabrinang]

Thanks for making the other changes! I found one more thing when I click on the other categories and click back to all ... the heading doesn't change back to all. For example when I visited pets and clicked all (should show All heading):

[fessehaye]

That is because the "ALL" link still points to mofo-staging.

Tagging @Pomax just to let him know but the all link does work properly on my dev env

done

done

[Pomax]

one code issue, but hitting "delete" in the search does not restore the category the user was on before they started searching. Instead, we stay on "all", but with the products not sorted on creepiness even though there is no search term,

E.g. be on a category:

start searching

delete search again:

If we want to keep the user on "all", then that's fine, but then we'll need to make sure to at the very least re-sort the products on creepiness (low to high ) when there is no text in the search box. I.e. the same ordering as when you intentionally navigate to All:

Done

[Pomax]

@sabrina when a user starts to search, and then deletes their search again (either though delete/backspace, or the (X) button) should we take the user back to the category they were on before they started searching, or do we keep the user on "all"?

[Pomax]

(for some reason the review had been marked as "comment" instead of "changes requested"...)

[sabrinang]

@Pomax I think it should just stay in "all" if they remove/start searching instead of going back to a previous catergory

[sabrinang]

Approving, Simon explained that "All" does have the right behaviour but isn't showing on staging