-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
updated/reordered CMS fields, removed price field, removed hint text #7769
Conversation
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
This PR introduces visual differences. Click here to inspect the diffs. |
Hi @kristinashu! Wanted to mention that ":" are appended by wagtail, so we are unable to remove them, unless the field name is ending with a "?", in which wagtail will display it in the CMS as a question |
This PR introduces visual differences. Click here to inspect the diffs. |
WOW I just entered a product using real content and it was so much easier and way way way faster! Even just having the category higher up on the page helped a bunch. I've only noticed a couple things: Character limitYou added a character limit to the blurbs. I did list a recommended max character count for those but that was guidance for Jen, which she has gone way over on so unfortunately we can't have a firm character limit in the cms or that will be a big blocker for content entry.
Move location of Time spent on reserachYou did match "Time spent on research" to the spreadsheet but I actually think it should be hire up in the CMS to better reflect the front-end design (I can ask Jen to move it up in the spreadsheet to match the design as well).
That's it! Thank you, this will make content entry so much smoother! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mozilla Says:
Should the dropdown labels be Thumbs Up
, Thumbs Down
, Thumb Sideways
directly instead of in the help text?
Ai is untrustworthy helptext:
I don't see this as a row on the spreadsheet, is it needed as a field in the CMS?
Validation Error
For example, I've been getting "Ensure this value has at most 700 characters (it has 3260)." Many of the contents for What could happen if something goes wrong?
goes over quite a bit when I use real content from the sheet. Some Intro Blurb:
contents are also exceeding to cause the validation error. +1 to what Kristina said to removing it to accommodate Jen’s content
re: what Kristina said about aligning with front-end design
+1 to spreadsheet/field order to reflect front-end design top-down so things in the General Product Details
can be reordered … ding, adult content, image, review date, mozilla says, wifi, bluetooth etc.
Software Product Page
It has different fields than the spreadsheet so I wasn’t sure if there is another spreadsheet I should refer to to review the Software Product pages. Are they still intentionally different?
Overall, this improves the content entry process and experience so much! I'm excited for this update to make things smoother and more efficient too!
Thank you so much Sabs! Mozilla Says:
This is a big lift so we need to just use the help text. Ai is untrustworthy helptext:
Good point! I think "General AI description" and "Ai is untrustworthy help text" are redundant
Validation Error
+1 this is the same as the remove max char limit re: what Kristina said about aligning with front-end design
Software Product Page
The Software Product pages are no longer used and will be removed so we I think we can ignore it now #7392 |
This PR introduces visual differences. Click here to inspect the diffs. |
This PR introduces visual differences. Click here to inspect the diffs. |
Hi @kristinashu @sabrinang thank you for the kind feedback! I have implemented the requests found in the comments and re-requested review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you Daniel! Really hoping this can land in time for the big content entry push tomorrow. It really will make things so much faster for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the updates Daniel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but this will need migrations renumbered before final approval
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
This PR introduces visual differences. Click here to inspect the diffs. |
Closes #7614
In this PR I did the following:
Test Pages:
**Link to test General Product Page in the CMS:**https://foundation-s-7614-updat-nn3k3e.herokuapp.com/cms/pages/73/edit/
**Link to test Software Product Page in the CMS:**https://foundation-s-7614-updat-nn3k3e.herokuapp.com/cms/pages/74/edit/
Steps to test: