Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

7708 - remember which category the user was on, to restore on search-clearing #7844

Merged
merged 2 commits into from
Nov 15, 2021
Merged

7708 - remember which category the user was on, to restore on search-clearing #7844

merged 2 commits into from
Nov 15, 2021

Conversation

fessehaye
Copy link
Contributor

Closes #7708

@mofodevops mofodevops temporarily deployed to foundation-s-7708-searc-3of8yx November 13, 2021 04:34 Inactive
@fessehaye fessehaye requested review from Pomax and sabrinang November 15, 2021 17:49
@Pomax
Copy link
Contributor

Pomax commented Nov 15, 2021

Looks like this isn't restoring the products for the category:

Pomax
Pomax previously requested changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@fessehaye fessehaye requested a review from Pomax November 15, 2021 18:42
sabrinang
sabrinang approved these changes Nov 15, 2021
View reviewed changes
Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After selecting a category, typing in search which searches in all and then clearing, it goes back to the previous selected category 👍

@Pomax Pomax merged commit 6d3cdde into main Nov 15, 2021
@Pomax Pomax deleted the 7708-search branch November 15, 2021 20:46
@Pomax Pomax temporarily deployed to foundation-s-7708-searc-3of8yx November 15, 2021 20:46 Inactive
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Pomax Pomax Pomax approved these changes

@sabrinang sabrinang sabrinang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PNI] Search (followup) - remember which category the user was on, to restore on search-clearing
4 participants
@fessehaye @Pomax @sabrinang @mofodevops