-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
sync cmake #1308
sync cmake #1308
Conversation
☀️ The build tests passed at 5c17ba0.
N.B. These results were obtained from a build of this Pull Request at 5c17ba0 after being merged into the base branch at 2d7b0cb. For more information, please check the job page here. |
📝 The HEAD of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ray. According to git diff --name-status I think you also need to add these files to cmake.
A CommonMC/src/MakeSurfaceSteps_module.cc
A CommonMC/src/SurfaceStepDiag_module.cc
A MCDataProducts/src/SurfaceStep.cc
Can you look after it. Then there are new cases for PR 1290 which was merged last night after you made this PR. Can you look after those too. git diff ---name-status tells me:
A EventGenerator/src/MuStopDecayPositionSamplerTool_tool.cc
A Mu2eG4/src/AtomicVolumeSamplerTool_tool.cc
A Mu2eG4/src/BoundMuonDecayFractionSamplerTool_tool.cc
A Mu2eG4/src/CompositeMaterialGenerator_module.cc
A Mu2eG4/src/ElementSamplerTool.cc
A Mu2eG4/src/WeightedElementSamplerTool.cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ray.
I won't rerun the CI since these changes have no coverage.
No description provided.