Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sync cmake #1308

Merged
merged 3 commits into from
Jul 11, 2024
Merged

sync cmake #1308

merged 3 commits into from
Jul 11, 2024

Conversation

rlcee
Copy link
Collaborator

@rlcee rlcee commented Jul 11, 2024

No description provided.

@FNALbuild
Copy link
Collaborator

Hi @rlcee,
You have proposed changes to files in these packages:

  • Print
  • DataProducts
  • KinKalGeom

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 5c17ba0: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 5c17ba0.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 5c17ba0 at 2d7b0cb
build (prof) Log file. Build time: 04 min 11 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 5c17ba0 after being merged into the base branch at 2d7b0cb.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to 8ab0f62. Tests are now out of date.

Copy link
Contributor

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ray. According to git diff --name-status I think you also need to add these files to cmake.

A CommonMC/src/MakeSurfaceSteps_module.cc
A CommonMC/src/SurfaceStepDiag_module.cc
A MCDataProducts/src/SurfaceStep.cc

Can you look after it. Then there are new cases for PR 1290 which was merged last night after you made this PR. Can you look after those too. git diff ---name-status tells me:

A EventGenerator/src/MuStopDecayPositionSamplerTool_tool.cc
A Mu2eG4/src/AtomicVolumeSamplerTool_tool.cc
A Mu2eG4/src/BoundMuonDecayFractionSamplerTool_tool.cc
A Mu2eG4/src/CompositeMaterialGenerator_module.cc
A Mu2eG4/src/ElementSamplerTool.cc
A Mu2eG4/src/WeightedElementSamplerTool.cc

@kutschke kutschke self-assigned this Jul 11, 2024
Copy link
Contributor

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ray.

I won't rerun the CI since these changes have no coverage.

@kutschke kutschke merged commit af80f04 into Mu2e:main Jul 11, 2024
1 of 2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants