Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix some references to null pointers #661

Merged
merged 1 commit into from
Nov 21, 2021
Merged

fix some references to null pointers #661

merged 1 commit into from
Nov 21, 2021

Conversation

rlcee
Copy link
Collaborator

@rlcee rlcee commented Nov 20, 2021

fsanitize test finds pointers that were not created were dereferenced. The pointers were not created because they were inside version checks, but this use was outside the version checks. This commit just moves the dereference to within version checks.

@FNALbuild
Copy link
Collaborator

Hi @rlcee,
You have proposed changes to files in these packages:

  • Mu2eG4

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

The following users requested to be notified about changes to these packages:
@resnegfk

⌛ The following tests have been triggered for ae117da: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The tests passed at ae117da.

Test Result Details
merge Merged ae117da at a62d09b
build (prof) Log file. Build time: 27 min 37 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at ae117da after being merged into the base branch at a62d09b.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Contributor

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is straightforward. Thanks for looking after it.

@kutschke kutschke merged commit 0e9e735 into Mu2e:main Nov 21, 2021
@kutschke kutschke self-assigned this Nov 21, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants