Allow CompressDetStepMCs to take in more than one SimParticleCollection

[AndrewEdmonds11]

For the cosmic ray simulations, we currently write out CRV StepPointMCs at the end of stage 1. Then in stage 2 we resample and create CrvSteps, along with StrawGasSteps and CaloShowerSteps, and then run CompressDetStepMCs.

To reduce the output file size in stage 1, we want to create CrvSteps and run CompressDetStepMCs at the end of stage 1. Then in stage 2, we would create StrawGasSteps and CaloShowerSteps and run CompressDetStepMCs again.

The only thing preventing this from being done is that CompressDetStepMCs can only take one SimParticleCollection as input. This PR changes that and allows for multiple input SimParticleCollections.

A few more points:

• this is an already-solved problem since we allow for multiple input SimParticleCollections in CompressDigiMCs and so I copied the relevant code from there
• there are changes needed to the fhicl configuration in the Production repo. I will put a PR in there shortly
• I tested on 10k events from a fhicl file Dave provided, It ran through digitization and reconsturction with no problems

Let me know if you have any questions or comments :)

[FNALbuild]

Hi @AndrewEdmonds11,
You have proposed changes to files in these packages:

• Compression

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for bf8edeb: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☔ The tests failed for bf8edeb.

Test	Result	Details
merge	✅	Merged bf8edeb at 9aaef54
build (prof)	✅	Log file. Build time: 29 min 50 sec
ceSimReco	❌	Log file. Return Code 9.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	❌	Log file. Return Code 9.
ceDigi	❌	Log file. Return Code 24.
muDauSteps	❌	Log file. Return Code 9.
ceMix	❌	Log file. Return Code 24.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 1 files
clang-tidy	〰️	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at bf8edeb after being merged into the base branch at 9aaef54.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[AndrewEdmonds11]

@FNALbuild run build tests with Mu2e/Production#144

[FNALbuild]

⌛ The following tests have been triggered for bf8edeb: build (Build queue is empty)

[FNALbuild]

☔ The tests failed for bf8edeb.

Test	Result	Details
test with	✅	Included Mu2e/Production#144 @ 74f69f2ba2211c9861464fafad16252ab9ee52c9 by merge
merge	✅	Merged bf8edeb at 9aaef54
build (prof)	✅	Log file. Build time: 13 min 24 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	❌	Log file. Return Code 9.
ceMix	❌	Log file. Return Code 1.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 1 files
clang-tidy	〰️	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at bf8edeb after being merged into the base branch at 9aaef54.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[brownd1978]

the ceMix failure is knock-on from the muDauSteps failure. That needs to be migrated to use the sequence of SimParticle collections: Module label: compressDetStepMCs module_type : CompressDetStepMCs Any parameters prefaced with '#' are optional. Missing parameters: - simParticleTags: [ - <art::InputTag>, - ... - ]

…

On Tue, Dec 7, 2021 at 10:58 AM Fermilab build bot account < ***@***.***> wrote: ☔ The tests failed for bf8edeb <bf8edeb> . Test Result Details test with ✅ Included Mu2e/Production#144 <Mu2e/Production#144> @ 74f69f2ba2211c9861464fafad16252ab9ee52c9 by merge merge ✅ Merged bf8edeb <bf8edeb> at 9aaef54 <9aaef54> build (prof) ✅ Log file <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/scons.log>. Build time: 13 min 24 sec ceSimReco ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/ceSimReco.log> g4test_03MT ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/g4test_03MT.log> transportOnly ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/transportOnly.log> POT ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/POT.log> g4study ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/g4study.log> cosmicSimReco ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/cosmicSimReco.log> cosmicOffSpill ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/cosmicOffSpill.log> ceSteps ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/ceSteps.log> ceDigi ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/ceDigi.log> muDauSteps ❌ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/muDauSteps.log> Return Code 9. ceMix ❌ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/ceMix.log> Return Code 1. rootOverlaps ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/rootOverlaps.log> g4surfaceCheck ✅ Log file. <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/g4surfaceCheck.log> FIXME, TODO ✅ TODO (0) FIXME (0) in 1 files <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/fixme_todo.log> clang-tidy 〰️ 0 errors 0 warnings <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/artifact/clang-tidy.log> N.B. These results were obtained from a build of this Pull Request at bf8edeb <bf8edeb> after being merged into the base branch at 9aaef54 <9aaef54> . For more information, please check the job page here <https://buildmaster.fnal.gov/buildmaster/job/GitHubPRTests/job/mu2e-offline-build-test//1081/console> . Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#669 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAH57Z2TFSLGKKE2VIDDPLUPZKNTANCNFSM5JRZZWCA> .

-- David Brown ***@***.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720

[AndrewEdmonds11]

Thanks, Dave. Looks like I had a typo in pileup/prolog.fcl. Let me try again...

[AndrewEdmonds11]

@FNALbuild run build tests with Mu2e/Production#144

[FNALbuild]

⌛ The following tests have been triggered for bf8edeb: build (Build queue is empty)

[FNALbuild]

☀️ The tests passed at bf8edeb.

Test	Result	Details
test with	✅	Included Mu2e/Production#144 @ 777c217ffee3b07c389aa7b80836d8136145e8c4 by merge
merge	✅	Merged bf8edeb at 9aaef54
build (prof)	✅	Log file. Build time: 12 min 53 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 1 files
clang-tidy	〰️	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at bf8edeb after being merged into the base branch at 9aaef54.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.