Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cosmic resampler fix #674

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Cosmic resampler fix #674

merged 1 commit into from
Dec 10, 2021

Conversation

brownd1978
Copy link
Collaborator

Resampling CrvSteps requires applying time offsets to these. Add the capability of time offsets for all the steps, for symmetry and future applications.

@brownd1978 brownd1978 requested a review from gaponenko December 9, 2021 19:30
@FNALbuild
Copy link
Collaborator

Hi @brownd1978,
You have proposed changes to files in these packages:

  • EventMixing
  • MCDataProducts

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 608b023: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The tests passed at 608b023.

Test Result Details
merge Merged 608b023 at 4271523
build (prof) Log file. Build time: 13 min 17 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 4 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 608b023 after being merged into the base branch at 4271523.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@kutschke kutschke self-assigned this Dec 9, 2021
@kutschke kutschke merged commit 2cdee13 into Mu2e:main Dec 10, 2021
@brownd1978 brownd1978 deleted the resamplerfix branch June 9, 2022 19:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants