Fix MCTrajectory reference updating. Add a comparison plot for CrvSteps

[brownd1978]

Hot fix for cosmic production

[FNALbuild]

Hi @brownd1978,
You have proposed changes to files in these packages:

• Validation
• Compression

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 743c0eb: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

[kutschke]

I understand the intent of the change and the implementation looks right to me. If Ralf's event display test works, I will be ready to approve and merge.

About my other comment: the last line should have read, "if time is tight feel free to make a separate PR after the tag."

[FNALbuild]

☀️ The tests passed at 743c0eb.

Test	Result	Details
merge	✅	Merged 743c0eb at 2cdee13
build (prof)	✅	Log file. Build time: 17 min 12 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 3 files
clang-tidy	〰️	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 743c0eb after being merged into the base branch at 2cdee13.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[brownd1978]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for 3c163dd: build (Build queue is empty)

[FNALbuild]

☔ The tests failed for 3c163dd.

Test	Result	Details
merge	✅	Merged 3c163dd at 2cdee13
build (prof)	✅	Log file. Build time: 13 min 34 sec
ceSimReco	❌	Log file. Return Code 134.
g4test_03MT	❌	Log file. Return Code 139.
transportOnly	❌	Log file. Return Code 139.
POT	❌	Log file. Return Code 139.
g4study	❌	Log file. Return Code 139.
cosmicSimReco	❌	Log file. Return Code 139.
cosmicOffSpill	❌	Log file. Return Code 134.
ceSteps	❌	Log file. Return Code 139.
ceDigi	❌	Log file. Return Code 134.
muDauSteps	❌	Log file. Return Code 139.
ceMix	❌	Log file. Return Code 134.
rootOverlaps	❌	Log file. Return Code 134.
g4surfaceCheck	❌	Log file. Return Code 134.
FIXME, TODO	✅	TODO (0) FIXME (0) in 3 files
clang-tidy	〰️	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 3c163dd after being merged into the base branch at 2cdee13.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[kutschke]

The previous failure looks like a Jenkins inftrastructure issue. Trying again.

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for 3c163dd: build (Build queue is empty)

[rlcee]

Very strange errors in the ceSimReco log, look at the versions in these two lines:
art v3_09_03 root v6_22_08d KinKal v00_01_08
Warning in TFile::Init: no StreamerInfo found in /cvmfs/mu2e.opensciencegrid.org/artexternals/root/v6_24_06b/

I don't know how this could happen except UPS being corrupt, or maybe Muse going horribly wrong..

[kutschke]

Or transient network problems. Or the Jenkins worker node is sick. In the hope that it’s transient, I resubmitted the CI. Note that the CI on PR 676 ran at essentially the same time and completed successfully. From: Ray Culbertson ***@***.***> Date: Monday, December 13, 2021 at 3:53 PM To: Mu2e/Offline ***@***.***> Cc: Rob Kutschke ***@***.***>, Assign ***@***.***> Subject: Re: [Mu2e/Offline] Fix MCTrajectory reference updating. Add a comparison plot for CrvSteps (PR #675) Very strange errors in the ceSimReco log, look at the versions in these two lines: art v3_09_03 root v6_22_08d KinKal v00_01_08 Warning in TFile::Init: no StreamerInfo found in /cvmfs/mu2e.opensciencegrid.org/artexternals/root/v6_24_06b/ I don't know how this could happen except UPS being corrupt, or maybe Muse going horribly wrong..

[FNALbuild]

☀️ The tests passed at 3c163dd.

Test	Result	Details
merge	✅	Merged 3c163dd at 2cdee13
build (prof)	✅	Log file. Build time: 12 min 51 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 3 files
clang-tidy	〰️	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 3c163dd after being merged into the base branch at 2cdee13.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[kutschke]

The retried CI worked. So the failure was some sort of transient issue or a sick worker node that we dodged on the retry. I will email Patrick.

In private email Ralf has said the the event display looks correct. So I will merge now.

[rlcee]

I still don't see any way that any number of failures accessing v6_22_08d could result in the code accessing v6_24_06b when that string is not mentioned anywhere in the build system. Very weird.

[kutschke]

… I had missed the version mismatch. This is definitely weird. From: Ray Culbertson ***@***.***> Reply-To: Mu2e/Offline ***@***.***> Date: Monday, December 13, 2021 at 4:17 PM To: Mu2e/Offline ***@***.***> Cc: Rob Kutschke ***@***.***>, State change ***@***.***> Subject: Re: [Mu2e/Offline] Fix MCTrajectory reference updating. Add a comparison plot for CrvSteps (PR #675) I still don't see any way that any number of failures accessing v6_22_08d could result in the code accessing v6_24_06b when that string is not mentioned anywhere in the build system. Very weird. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Mu2e_Offline_pull_675-23issuecomment-2D992960744&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=Wp0mFF8GiOGC6ip2Y8Ys-Zf3lw_SzWg9pmpmAHem44E&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABHY5ZSBB2VDQNL7XVOMQS3UQZWHFANCNFSM5J66JWAQ&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=cVl5DrE3vy12nQoQh5UsA0EudrJOLUo20nNhw7mfzIo&e=>. Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=ahEVmT0pF_silIjzPNyS-owKj8ZYPOvLh5zo_wvi4bA&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=kj02bUVgQTcVms9J_P8SOX_4FyFguRfYPKFKOCbX0a4&e=>.

[brownd1978]

stale cache?

…

On Mon, Dec 13, 2021 at 2:25 PM Rob Kutschke ***@***.***> wrote: … I had missed the version mismatch. This is definitely weird. From: Ray Culbertson ***@***.***> Reply-To: Mu2e/Offline ***@***.***> Date: Monday, December 13, 2021 at 4:17 PM To: Mu2e/Offline ***@***.***> Cc: Rob Kutschke ***@***.***>, State change ***@***.***> Subject: Re: [Mu2e/Offline] Fix MCTrajectory reference updating. Add a comparison plot for CrvSteps (PR #675) I still don't see any way that any number of failures accessing v6_22_08d could result in the code accessing v6_24_06b when that string is not mentioned anywhere in the build system. Very weird. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Mu2e_Offline_pull_675-23issuecomment-2D992960744&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=Wp0mFF8GiOGC6ip2Y8Ys-Zf3lw_SzWg9pmpmAHem44E&e=>, or unsubscribe< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABHY5ZSBB2VDQNL7XVOMQS3UQZWHFANCNFSM5J66JWAQ&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=cVl5DrE3vy12nQoQh5UsA0EudrJOLUo20nNhw7mfzIo&e=>. Triage notifications on the go with GitHub Mobile for iOS< https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=ahEVmT0pF_silIjzPNyS-owKj8ZYPOvLh5zo_wvi4bA&e=> or Android< https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=Zi5IH-k2_JiK_Wipiv3pwwSXO9UNaHiLP8sisfPz__k&m=kF5unC7B68q-EoixznJbyAhWg1AtKE6o2JbhB-3LMr11ByUyNiG-zelQ0wovBrHn&s=kj02bUVgQTcVms9J_P8SOX_4FyFguRfYPKFKOCbX0a4&e=>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#675 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAH576MJMXHM7TMCREQ2LLUQZXENANCNFSM5J66JWAQ> .

-- David Brown ***@***.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720