-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
constant reference edits for TFileDirectory objects #676
Conversation
☀️ The tests passed at cc6e1ca.
N.B. These results were obtained from a build of this Pull Request at cc6e1ca after being merged into the base branch at 2cdee13. For more information, please check the job page here. |
📝 The HEAD of |
@FNALbuild run build test |
⌛ The following tests have been triggered for cc6e1ca: build (Build queue is empty) |
☀️ The tests passed at cc6e1ca.
N.B. These results were obtained from a build of this Pull Request at cc6e1ca after being merged into the base branch at d582a8d. For more information, please check the job page here. |
This work is intermediate work being completed between iterations of art, v3.9 and v3.10, where TFileDirectory objects now need to be passed by constant reference. The modifications here were validated with 1k ceSimReco events against a reference branch, returning perfect matches:
macndev@mu2ebuild01.fnal.gov:/mu2e/app/users/macndev/OfflineArt310_ref:valCompare -s val_ref.root ../OfflineArt310/val_working.root
TValCompare Status Summary:
370 Compared
6 marked to skip
0 had unknown status
0 could not be compared
24 had at least one histogram empty
0 failed loose comparison
0 passed loose comparison, failed tight
0 passed tight comparison, not perfect match
364 had perfect match
364 passed loose or better
364 passed tight or better