Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

constant reference edits for TFileDirectory objects #676

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

macndev
Copy link
Contributor

@macndev macndev commented Dec 13, 2021

This work is intermediate work being completed between iterations of art, v3.9 and v3.10, where TFileDirectory objects now need to be passed by constant reference. The modifications here were validated with 1k ceSimReco events against a reference branch, returning perfect matches:

macndev@mu2ebuild01.fnal.gov:/mu2e/app/users/macndev/OfflineArt310_ref:valCompare -s val_ref.root ../OfflineArt310/val_working.root
TValCompare Status Summary:
370 Compared
6 marked to skip
0 had unknown status
0 could not be compared
24 had at least one histogram empty
0 failed loose comparison
0 passed loose comparison, failed tight
0 passed tight comparison, not perfect match
364 had perfect match
364 passed loose or better
364 passed tight or better

@FNALbuild
Copy link
Collaborator

Hi @macndev,
You have proposed changes to files in these packages:

  • Validation

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for cc6e1ca: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The tests passed at cc6e1ca.

Test Result Details
merge Merged cc6e1ca at 2cdee13
build (prof) Log file. Build time: 27 min 39 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 〰️ TODO (0) FIXME (1) in 73 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at cc6e1ca after being merged into the base branch at 2cdee13.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to d582a8d. Tests are now out of date.

@kutschke
Copy link
Contributor

@FNALbuild run build test

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for cc6e1ca: build (Build queue is empty)

@FNALbuild
Copy link
Collaborator

☀️ The tests passed at cc6e1ca.

Test Result Details
merge Merged cc6e1ca at d582a8d
build (prof) Log file. Build time: 13 min 49 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 〰️ TODO (0) FIXME (1) in 73 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at cc6e1ca after being merged into the base branch at d582a8d.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@kutschke kutschke merged commit a551008 into Mu2e:main Dec 14, 2021
@macndev macndev mentioned this pull request Jan 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants