-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
move ParticleDataTable uses to new ParticleDataList #680
Conversation
Hi @rlcee,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. The following users requested to be notified about changes to these packages: ⌛ The following tests have been triggered for 3ebb0ef: build (Build queue is empty) |
☀️ The tests passed at 3ebb0ef.
N.B. These results were obtained from a build of this Pull Request at 3ebb0ef after being merged into the base branch at 7cc7f0e. For more information, please check the job page here. |
WHen you say that you checked TrackerAlignment and REve, do you mean that they do not currently use the old system and therefore need no maintenance? Is that correct? I see the PR in TrkAna. Have you looked at TrackerMCTune? Outside of this PR the appropriate people will need to look at Tutorial and Stntuple. |
Yes
TrackerMCTune doesn't use ParticleDataTable
Tutorial doesn't use ParticleDataTable |
Thanks Ray. I am surprised that Tutorial does not use ParticleDataTable but it's certainly simpler that it does not. |
#672 references the ParticleDataTable include, which should be removed since it is not used. This can be done independently from this PR. If I run the geant particle print routine, which prints 6 sig fig, and compare to the text in the new particle table, all the printed digits agree exactly for the mass of the ele, mu, pi0 and pi+. This is not definitive since the variables are doubles, but I'd have to figure out some code to go further in sig fig. Let me know if I have to do that. |
📝 The HEAD of |
@FNALbuild run build test |
⌛ The following tests have been triggered for 3ebb0ef: build (Build queue has 3 jobs) |
☀️ The tests passed at 3ebb0ef.
N.B. These results were obtained from a build of this Pull Request at 3ebb0ef after being merged into the base branch at b220f75. For more information, please check the job page here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ray's tests show exact matches and the changes are straightforward. I am approve this and will merge.
Switch to new, simpler ParticleDataList. Validation tests
show exact matches. I know this is a precise test because a few small diffs in precision with the old system did show differences in the ceSimReco and reco validation.
I also checked uses in TrackerAlignment, REve and TrkAna, and there will be one follow-on commit in TrkAna.