Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

changed names of included prolog namespaces from the offline #324

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

gianipez
Copy link
Contributor

No description provided.

@FNALbuild
Copy link
Collaborator

Hi @gianipez,
You have proposed changes to files in these packages:

  • Processing
  • JobConfig

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for c842ef8: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for c842ef8.

Test Result Details
test with Command did not list any other PRs to include
merge Merged c842ef8 at f5cc231
build (prof) Log file. Build time: 04 min 10 sec
ceSimReco Log file. Return Code 90.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file. Return Code 90.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at c842ef8 after being merged into the base branch at f5cc231.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

This PR depends from Mu2e/Offline#1286

@kutschke
Copy link
Collaborator

This PR depends from Mu2e/Offline#1286

Does this mean that you need to use "test with" to run the CI?

@gianipez
Copy link
Contributor Author

This PR depends from Mu2e/Offline#1286

Does this mean that you need to use "test with" to run the CI?

Yes please. I forgot how to run that command.

@kutschke
Copy link
Collaborator

This PR depends from Mu2e/Offline#1286

Does this mean that you need to use "test with" to run the CI?

Yes please. I forgot how to run that command.

See https://mu2ewiki.fnal.gov/wiki/GitHubWorkflow#GitHub_Pull_Request_Procedures_and_FNALbuild

@FNALbuild run build test with Mu2e/Offline#1286

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for c842ef8: build (Build queue is empty)

@kutschke
Copy link
Collaborator

And the AL9 build machines are about 4x faster than the SL7 ones.

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for c842ef8.

Test Result Details
test with Included Mu2e/Offline#1286 @ 8c58d63167b96c72e8f014c1fc9990bc3fe4db4a by merge
merge Merged c842ef8 at f5cc231
build (prof) Log file. Build time: 04 min 08 sec
ceSimReco Log file. Return Code 90.
g4test_03MT Log file. Return Code 90.
transportOnly Log file. Return Code 90.
POT Log file.
g4study Log file. Return Code 90.
cosmicSimReco Log file. Return Code 90.
cosmicOffSpill Log file. Return Code 90.
ceSteps Log file. Return Code 90.
ceDigi Log file. Return Code 90.
muDauSteps Log file. Return Code 90.
ceMix Log file. Return Code 90.
rootOverlaps Log file. Return Code 90.
g4surfaceCheck Log file. Return Code 90.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at c842ef8 after being merged into the base branch at f5cc231.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

gianipez commented Jun 16, 2024

@FNALbuild run build test with Mu2e/Offline#1286, Mu2e/mu2e_trig_config#31

@gianipez
Copy link
Contributor Author

@FNALbuild run build test with Mu2e/Offline#1286 , Mu2e/mu2e_trig_config#31

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for 1c98b8e: build (already triggered: build) (Build queue is empty)

@kutschke
Copy link
Collaborator

@FNALbuild run build test with Mu2e/Offline#1286, Mu2e/mu2e_trig_config#31

We have not added any code to support test with for mu2e_trig_config. I don't expect it to work but I could be wrong. We tried it once before it failed. But we later learned that there were other problems occuring at the same time so it's possible we did not have a clean test.

@gianipez
Copy link
Contributor Author

@FNALbuild run build test with Mu2e/Offline#1286

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for 1c98b8e.

Test Result Details
test with Included Mu2e/Offline#1286 @ 804507f46f5eb3e6083904f8370102c59030215a by merge
test with Failed to retrieve request base branch commit sha for Mu2e/mu2e_trig_config#31, default is to merge into main
test with Included Mu2e/mu2e_trig_config#31 @ 691fe8c4c32c385ba06eb52d91dd294ddf494120 by merge
merge Merged 1c98b8e at f5cc231
build (prof) Log file. Build time: 04 min 09 sec
ceSimReco Log file.
g4test_03MT Log file. Return Code 90.
transportOnly Log file. Return Code 90.
POT Log file.
g4study Log file. Return Code 90.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file. Return Code 90.
ceDigi Log file. Return Code 24.
muDauSteps Log file. Return Code 90.
ceMix Log file. Return Code 90.
rootOverlaps Log file. Return Code 90.
g4surfaceCheck Log file. Return Code 90.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 1c98b8e after being merged into the base branch at f5cc231.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

@FNALbuild run build test with Mu2e/Offline#1286

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for 13294ae: build (Build queue is empty)

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for 13294ae.

Test Result Details
test with Included Mu2e/Offline#1286 @ babafd56bb70b86702a10b7587a787b21d225b1b by merge
merge Merged 13294ae at f5cc231
build (prof) Log file. Build time: 04 min 09 sec
ceSimReco Log file. Return Code 90.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file. Return Code 90.
cosmicOffSpill Log file. Return Code 90.
ceSteps Log file.
ceDigi Log file. Return Code 90.
muDauSteps Log file.
ceMix Log file. Return Code 90.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 13294ae after being merged into the base branch at f5cc231.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

All the errors left are because the tests are not including Mu2e/mu2e_trig_config#31
I'm waiting for @brownd1978 for merging it w/o creating conflicts with Mu2e/mu2e_trig_config#27

@kutschke kutschke self-assigned this Jun 17, 2024
Copy link
Collaborator

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond scope of this PR, we have to better separate the MC-truth matching part of the reco sequence from the pure reco sequence.

Copy link
Collaborator

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the merging mu2e_trig_config PR 31, I launched the CI using test with this PR from Offline PR#1286 . It passed

@kutschke kutschke merged commit 1f5d9f9 into Mu2e:main Jun 18, 2024
8 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants