Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for ts3server query commands #1

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Support for ts3server query commands #1

merged 1 commit into from
Sep 30, 2018

Conversation

Chrisg2000
Copy link
Contributor

@Chrisg2000 Chrisg2000 commented Sep 29, 2018

Adds support for all now and in future available ts3server query commands.
In Events.py: data field should be a dict with accessible entries rather than a list of keys of an inaccessible dict

Copy link
Owner

@Murgeye Murgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks for your contribution.

That list(data) stuff was written a long time ago, I cannot even remember what the idea was behind that. Maybe a copy of the data dictionary would be better in case the data is ever used anywhere else? (Should not happen for now, but who knows)

Anyways, approved!

@Murgeye Murgeye merged commit ed5b976 into Murgeye:master Sep 30, 2018
@Chrisg2000
Copy link
Contributor Author

Thanks for accepting my changes.
Although I forgot to add something which I will add in my next pull request.

I think it is not needed to use a copy of the data dictionary. The _data dict is available through the data property, which is read-only, and all necessary properties for a event are retrieved via the original data variable inside the init function head.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants