This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's -> its pet peeve, and I like to imagine I'm not alone.
rpc: allow dumb empty requests for AWS health checks
…#15499) * core/vm, internal/ethapi: tracer no full storage, nicer json output * core/vm, internal/ethapi: omit disabled trace fields
Fixes #15493
rpc: minor cleanups to RPC PR
internal/ethapi: changed output in txpool.inspect
Fix typo in README.md
* Add method getBalanceFromJs for work with address as bytes * expect []byte instead of common.Address in ethapi tracer
accounts: fix two races in the account manager
accounts/keystore: Ignore initial trigger of rescan-event
…e diffs (#15512) * eth, internal: Implement using trie diffs * eth, internal: Changes in response to review * eth: More fixes to getModifiedAccountsBy* * eth: minor polishes on error capitalization
internal/ethapi: avoid recreating JavaScript tracer wrappers
* cmd, consensus, eth: split ethash related config to it own * eth, consensus: minor polish * eth, consenus, console: compress pow testing config field to single one * consensus, eth: document pow mode
accounts/keystore: change modtime for test case files to be bigger than 1sec.
swarm/api: bug fix exact match for manifest
core/state: copy trie too, not just content
* Disallow --lightserv in light mode * Reformatted * cmd/utils: reduce nesting levels a bit
Builds fine with go1.9 on Unix. |
Varunram
approved these changes
Dec 1, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me
Was about to point those fixed, thanks @5chdn! I'll merge this one. |
Reverting to this branch for 2.6.1 |
off the topic, I can imagine more future bumps with Ethereum, if they keep adding more unstable features without a broader view of its lifecycle. |
ghost
reviewed
Jun 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes since v2.5.3 include:
Closes #70