[FEATURE] Allow user to define media types to keep and keep print type by default #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Renkas , thanks for the PR! Could you please squash the two commits and then rebase? I've just merged some PRs. Thanks! |
| $this->subject->setCss($css); | ||
| $this->subject->removeAllowedMediaType('print'); | ||
|
|
||
| $this->assertNotContains( |
There was a problem hiding this comment.
Could you please make the assert call static (using self::)?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think print styles should be kept by default. But now user can manage himself what types to keep/drop.
Original #68